Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/stackdriver: allow credentials file #1734

Closed
sbernierlacapitale opened this issue Dec 1, 2020 · 6 comments
Closed

exporter/stackdriver: allow credentials file #1734

sbernierlacapitale opened this issue Dec 1, 2020 · 6 comments
Assignees
Labels
comp:google Google Cloud components enhancement New feature or request priority:p3 Lowest release:after-ga

Comments

@sbernierlacapitale
Copy link

sbernierlacapitale commented Dec 1, 2020

Is your feature request related to a problem? Please describe.
Traces are exported to Google Cloud Trace to the application's project. It is currently impossible (?) to specify another project as the target for these traces, or to use a specific service account.

For example, the traces sent to a collector hosted on GKE cannot easily be exported to Cloud Trace in another project, using another service account.

Describe the solution you'd like
Specifying a credentials file's path in the collector config would solve this issue. This file is the JWT public key specified at https://cloud.google.com/iot/docs/how-tos/credentials/jwts.

Describe alternatives you've considered
The only alternative that I know of is to clone this repo, manually add this ability, and build a new image to deploy.

Additional context
The modified code is essentially

if cfg.CredentialsPath != "" {
    copts = append(copts, option.WithCredentialsFile(cfg.CredentialsPath))
}

The collector's config file can then contain the following:

exporters:
  stackdriver:
    project: "my_project"
    credentials_path: "/path/to/credentials.json"

If this is considered as an interesting change, I can make a PR with the changes if needed.

@andrewhsu
Copy link
Member

from the triage session at the sig mtg today, @dashpole volunteered to be assignee of this issue

@andrewhsu andrewhsu added enhancement New feature or request release:after-ga and removed feature request labels Dec 9, 2020
@alolita alolita added the comp:google Google Cloud components label Sep 8, 2021
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
According to the [community
charter](https://github.com/open-telemetry/community/blob/main/community-membership.md#responsibilities-and-privileges-2):

> Expected to be responsive to review requests (inactivity for more than
> 1 month may result in suspension until active again)

Given @paivagustavo has returned to an active state, this reinstates
their status as an Approver.
prashant-shahi referenced this issue in prashant-shahi/opentelemetry-collector-contrib Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2022

This will be fixed by GoogleCloudPlatform/opentelemetry-operations-go#527

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 20, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
@dashpole
Copy link
Contributor

This was fixed by GoogleCloudPlatform/opentelemetry-operations-go#527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:google Google Cloud components enhancement New feature or request priority:p3 Lowest release:after-ga
Projects
None yet
Development

No branches or pull requests

6 participants