Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stop using inject framework in controller-runtime #958

Merged

Conversation

justinsb
Copy link
Collaborator

The inject framework has been removed, so we need this to continue to
update controller-runtime.

The inject framework has been removed, so we need this to continue to
update controller-runtime.
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diviner524
Copy link
Collaborator

The inject framework has been removed, so we need this to continue to update controller-runtime.

Thank you for making the change @justinsb! Just for self-education, could you also share a link with more details on the removal of inject framework?

@diviner524
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 25, 2023
@google-oss-prow google-oss-prow bot merged commit 965bc17 into GoogleCloudPlatform:master Oct 25, 2023
5 checks passed
@justinsb
Copy link
Collaborator Author

I think the canonical reference for inject deprecation is kubernetes-sigs/controller-runtime#1433

What really breaks us though is that https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/runtime/inject is removed after 0.14.6, that stops (future) updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants