Fixes broken shim and tests for lifeycycle,cors,web,logging and acl commands #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kautikdk
commented
Apr 26, 2024
•
kautikdk
commented
- Fixes broken shim for lifecycle, logging, web, requesterpays and cors commands.
- Removes --raw flag from acl command shim translation.
… commands. Removes raw flag from acl command.
kautikdk
force-pushed
the
shim-fixes-and-raw-removal
branch
from
fdc3877
to
c583397
Compare
|
/gcbrun |
kautikdk
changed the title
sushantkhanna
approved these changes
May 15, 2024
|
@sushantkhanna has reviewed the PR. Merging |
shilpi23pandey
merged commit a32d8f5
into
GoogleCloudPlatform:master
27 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.