-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Cloud SQL Proxy v2 in READMEs #3998
base: main
Are you sure you want to change the base?
Conversation
Also remove references to service account keys in favor of application default credentials. Related to GoogleCloudPlatform/nodejs-docs-samples#3635
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; Thanks for proactively updating go readmes in addition to the Node.js ones.
1. Create a service account with the 'Cloud SQL Client' permissions by following these | ||
[instructions](https://cloud.google.com/sql/docs/mysql/connect-external-app#4_if_required_by_your_authentication_method_create_a_service_account). | ||
Download a JSON key to use to authenticate your connection. | ||
1. Set up [Application Default Credentials][adc] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enocom probably still worth highlighting the need of the Cloud SQL Client
IAM role?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Also remove references to service account keys in favor of application default credentials.
Related to GoogleCloudPlatform/nodejs-docs-samples#3635