Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add autoclass samples #2737

Merged
merged 6 commits into from Nov 7, 2022
Merged

feat(storage): add autoclass samples #2737

merged 6 commits into from Nov 7, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 10, 2022 •
edited

Fixes #2707

Requires googleapis/google-cloud-go#6828
Tests pass locally with library feature support

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Oct 10, 2022
@tritone tritone self-assigned this Oct 13, 2022
@cojenco cojenco marked this pull request as ready for review October 18, 2022 20:13
@cojenco cojenco requested review from a team as code owners October 18, 2022 20:13
@snippet-bot
Copy link

snippet-bot bot commented Oct 18, 2022 •
edited

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 19, 2022
@cojenco cojenco requested a review from tritone October 19, 2022 20:35
BrennaEpp
BrennaEpp reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cathy :)

storage/buckets/set_autoclass.go Outdated Show resolved Hide resolved
storage/buckets/set_autoclass.go Outdated Show resolved Hide resolved
storage/buckets/get_autoclass.go Show resolved Hide resolved
storage/buckets/get_autoclass.go Outdated Show resolved Hide resolved
BrennaEpp
BrennaEpp approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2022
@tritone tritone merged commit 4f992b8 into GoogleCloudPlatform:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennaEpp BrennaEpp BrennaEpp approved these changes

@tritone tritone Awaiting requested review from tritone

Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: add samples for Autoclass
3 participants
@cojenco @BrennaEpp @tritone