Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update google.golang.org/api to v0.50.0 #2127

Merged
merged 1 commit into from Jul 1, 2021
Merged

fix: update google.golang.org/api to v0.50.0 #2127

merged 1 commit into from Jul 1, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 30, 2021 •
edited

Only updated modules that used idtoken and could have experienced this issue.

Fixes: #2125

@codyoss codyoss requested a review from a team June 30, 2021 19:03
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2021
tbpg
tbpg requested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some empty files? Also, are we sure we need to add require lines where they weren't there before?

@codyoss
Copy link
Member Author

codyoss commented Jun 30, 2021

It seems like my script was overzealous, 👀

@codyoss
Copy link
Member Author

codyoss commented Jun 30, 2021

Hmm this still does not seem great, one more try

@codyoss codyoss requested a review from tbpg June 30, 2021 19:35
@tbpg tbpg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2021
@codyoss codyoss merged commit 79e041c into GoogleCloudPlatform:master Jul 1, 2021
@codyoss codyoss deleted the update-apiary branch July 1, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: functions/security/idtoken.go
3 participants
@codyoss @tbpg @kokoro-team