Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add change default storage class sample #1791

Merged
merged 7 commits into from Feb 5, 2021
Merged

feat(storage): add change default storage class sample #1791

merged 7 commits into from Feb 5, 2021

Conversation

AlisskaPie
Copy link
Contributor

@AlisskaPie AlisskaPie commented Oct 22, 2020 •
edited

Related to #1707

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@AlisskaPie
Copy link
Contributor Author

AlisskaPie commented Oct 22, 2020 •
edited

This PR has been merged. Waiting for storage release.

@tbpg tbpg added the api: storage Issues related to the Cloud Storage API. label Oct 22, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 23, 2020
@snippet-bot
Copy link

snippet-bot bot commented Dec 1, 2020 •
edited

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tbpg tbpg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 9, 2020
@frankyn frankyn self-requested a review February 3, 2021 21:29
@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 3, 2021
@frankyn frankyn marked this pull request as ready for review February 3, 2021 21:33
@frankyn frankyn added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 3, 2021
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
tritone
tritone reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update to go.mod for CI to pass.

storage/buckets/change_default_storage_class.go Outdated
defer cancel()

bucket := client.Bucket(bucketName)
// See the StorageClass documentation for other valid storage classes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not necessary; it's embedded in a page that contains this link and other languages don't have it.

@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 5, 2021
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@tritone
Copy link
Contributor

tritone commented Feb 5, 2021

Looks like there was a spanner integration test flake on go1.11. I'll re-run.

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit aaab0c3 into GoogleCloudPlatform:master Feb 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@tbpg tbpg tbpg approved these changes

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AlisskaPie @tritone @tbpg @frankyn @kokoro-team