Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: functions/security/idtoken.go #2125

Closed
bweston92 opened this issue Jun 28, 2021 · 1 comment · Fixed by #2127
Closed

bug: functions/security/idtoken.go #2125

bweston92 opened this issue Jun 28, 2021 · 1 comment · Fixed by #2127
Assignees
@codyoss
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bweston92
Copy link

bweston92 commented Jun 28, 2021 •
edited

The following doesn't seem to work:

https://github.com/GoogleCloudPlatform/golang-samples/blob/HEAD/functions/security/idtoken.go

by default using a service account file with it I get the following:

neither scopes or audience are available for the self-signed JWT

I can get it to make a request but have to use option.WithAudiences(targetURL) in the call to idtoken.NewClient and it works fine.

Is this desired behaviour?
If so can improve these documents?
If not, where should I list a bug?
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 28, 2021
@bweston92 bweston92 mentioned this issue Jun 29, 2021
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 29, 2021
@tbpg tbpg added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Jun 29, 2021
@codyoss
Copy link
Member

codyoss commented Jun 29, 2021

This is being tracked on google-api-go-client and has a fix out for review. For now please use google.golang.org/api@v0.48.0, sorry for the inconvenience.

@codyoss codyoss mentioned this issue Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update google.golang.org/api to v0.50.0
4 participants
@bweston92 @codyoss @tbpg @yoshi-automation