DontReview Call ls -R from within mount #1928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call runs `ls -R` on mount-directory, right after returning successful mount to user. This initiates the `ls -R` in a separate goroutine. On completion of this goroutine, if there is an error, then it is logged in gcsfuse debug log-file. The `ls -R` is simulated with filepath.WalkDir which recursively visits each sub-directory and takes count of all files/directories.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
- Coverage 61.44% 61.42% -0.02%
==========================================
Files 129 129
Lines 12298 12310 +12
==========================================
+ Hits 7557 7562 +5
- Misses 4402 4410 +8
+ Partials 339 338 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closed in favour of #1930 . |
gargnitingoogle
deleted the
gargnitin/listing-during-mount/2-async-right-after-mount/v1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call runs
ls -Ron mount-directory,right after returning successful mount to user.
This initiates the
ls -Rin a separategoroutine. On completion of this goroutine,
if there is an error, then it is logged
in gcsfuse debug log-file.
The
ls -Ris simulated with filepath.WalkDirwhich recursively visits each sub-directory
and takes count of all files/directories.
Description
Link to the issue in case of a bug fix.
NA
Testing details