[PR1] Support to keep ReadDir response in kernel cache #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-prince
changed the title
raj-prince
changed the title
raj-prince
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1897 +/- ##
==========================================
+ Coverage 60.76% 61.28% +0.52%
==========================================
Files 130 130
Lines 12397 12458 +61
==========================================
+ Hits 7533 7635 +102
+ Misses 4526 4480 -46
- Partials 338 343 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sethiay
reviewed
May 23, 2024
sethiay
reviewed
May 23, 2024
sethiay
reviewed
May 23, 2024
There was a problem hiding this comment.
@raj-prince I've reviewed the full code here and added some comments.
This also needs some integration tests or new configurations added in the existing integration tests. Please add.
gargnitingoogle
requested changes
May 23, 2024
gargnitingoogle
requested changes
May 23, 2024
gargnitingoogle
previously approved these changes
May 24, 2024
|
Perf test result: Although triggered again since the previous build aborted due to unavailable executor. |
|
Perf looks good: |
charith87
approved these changes
May 25, 2024
sethiay
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a configuration under FileSystem - kernel-dir-cache-ttl-secs
Supported cli flag --kernel-dir-cache-ttl-secs, whose value will take precedence over config.
With this support list response as part of
lscommand will be saved in the kernel and invalidated based on the kernel-dir-cache-ttl-secs.Kernel doesn't keep list response partially, either complete response or none.
Link to the issue in case of a bug fix.
NA
Testing details