-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BucketType method to locally store bucketType in variable #1896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just few nits, please fix those, rest looks good to me
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1896 +/- ##
=========================================
Coverage ? 61.35%
=========================================
Files ? 129
Lines ? 12326
Branches ? 0
=========================================
Hits ? 7563
Misses ? 4425
Partials ? 338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Create BucketType() method to returns the type of bucket, allowing the use of a new API specifically designed for HNS buckets.
Link to the issue in case of a bug fix.
NA
Testing details