feat: add support for unix sockets (linux, mac, and windows) #1182
+466
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
suggested changes
Apr 22, 2022
This reverts commit 1eb72ce.
|
I've updated the Postgres e2e test to use pgx to help ease the transition to v2. As part of that, I discovered pgx does not support Unix sockets on Windows, but fixing that would be only a small amount of work. I've filed jackc/pgx#1199 and otherwise disabled the test on Windows for now. |
enocom
changed the title
|
Added supported for Unix sockets for Windows in pgx here: jackc/pgconn#114 and there's already a new release with the patch in it. I've updated the PR here to use that latest version. |
kurtisvg
approved these changes
May 20, 2022
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
May 26, 2022
This is an adaptation from GoogleCloudPlatform/cloud-sql-proxy#1182
enocom
added a commit
to GoogleCloudPlatform/alloydb-auth-proxy
that referenced
this pull request
May 31, 2022
This is an adaptation from GoogleCloudPlatform/cloud-sql-proxy#1182
enocom
added a commit
that referenced
this pull request
Jun 17, 2022
enocom
added a commit
that referenced
this pull request
Jul 12, 2022
enocom
added a commit
that referenced
this pull request
Jul 27, 2022
enocom
added a commit
that referenced
this pull request
Aug 23, 2022
enocom
added a commit
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84