fix(tft): remove default retry of inconsistent provider #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
changed the title
bharathkkb
reviewed
May 17, 2024
| @@ -309,6 +309,9 @@ func (b *TFBlueprintTest) GetTFOptions() *terraform.Options { | |||
| RetryableTerraformErrors: b.retryableTerraformErrors, | |||
| NoColor: true, | |||
| }) | |||
| // Remove Default "rovider produced inconsistent result after apply" from RetryableTerraformErrors | |||
| // Retrying these errors generally results in confusing already exist errors | |||
| delete(newOptions.RetryableTerraformErrors, ".*Provider produced inconsistent result after apply.*") | |||
There was a problem hiding this comment.
Couldn't we remove these at the call sites?
There was a problem hiding this comment.
This removal is for one that is pulled in with a larger list from the ealier terraform.WithDefaultRetryableErrors call: https://github.com/gruntwork-io/terratest/blob/master/modules/terraform/options.go#L14
bharathkkb
approved these changes
May 17, 2024
|
Going to leave this out for now. If we decide to add we should make if configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.