Add notebook on grounding with Vertex AI Agent Builder #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,414 @@ | |||
| { | |||
There was a problem hiding this comment.
- The link "Vertex AI Agent Builder" goes to vertex search. Is that intended?
- Something off with the sentence "By grounding model responses in data stores within Vertex AI Agent Builder, LLMs that are grounded in data can produce more accurate, up-to-date, and relevant responses." Maybe delete "that are grounded in data"
Reply via ReviewNB
| @@ -0,0 +1,414 @@ | |||
| { | |||
There was a problem hiding this comment.
- Is it feasible to add a programatic version to these UI instructions? I think both are valuable.
- In the instructions, I'd suggest concrete values to input: e.g. "enter the name of your app" --> "enter the name of your app (for example: Google Store App)
- Maybe specify what "advanced website indexing" is and why we need to turn it off. Same thing for "Advanced LLM features"
Reply via ReviewNB
| @@ -0,0 +1,414 @@ | |||
| { | |||
There was a problem hiding this comment.
It would be nice if we could retrieve DATA_STORE_ID programmatically if that's feasible.
Reply via ReviewNB
| @@ -0,0 +1,414 @@ | |||
| { | |||
There was a problem hiding this comment.
I am not seeing any tools keyword arg in the cell below, only a goundig_source arg. Typo?
Reply via ReviewNB
BenoitDherin
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notebook adds a how to use Vertex Agent Builder and ground responses using the PaLM model.