Markdown fixes #321
Merged
Markdown fixes #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
🚀 Deploy preview for 15f7a1b: firebase-preview-action |
surma
reviewed
Jun 17, 2020
| if (infostring === 'sh') { | ||
| infostring = ''; | ||
| infostring = 'shell-session'; |
developit
approved these changes
Jun 17, 2020
surma
reviewed
Jun 17, 2020
| @@ -23,7 +23,7 @@ export function createRenderer() { | |||
| if (infostring === 'sh') { | |||
| infostring = ''; | |||
| } | |||
| if (!infostring || infostring.length <= 0) { | |||
| if (!infostring) { | |||
There was a problem hiding this comment.
Because I never think of "" as a false-y value 🙄
There was a problem hiding this comment.
To be fair, it took me a while to notice it
RReverser
reviewed
Jun 17, 2020
| <!DOCTYPE html> | ||
| … | ||
| ```html | ||
| <!DOCTYPE html> … |
There was a problem hiding this comment.
@jakearchibald Is this an intentional change? Seems weird that they're on the same line now.
There was a problem hiding this comment.
It was Prettier enforced, but it didn't seem like a big enough deal to somehow avoid.
There was a problem hiding this comment.
Seems a bit weird for reading, but ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304.
Fixes #316.
Also updated other packages.