Correctly escape code blocks. Fixes #316

GoogleChromeLabs · Jun 17, 2020 · 4dfb4d2 · 4dfb4d2
1 parent f8238cc
commit 4dfb4d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/markdown-renderer.js b/lib/markdown-renderer.js
@@ -11,6 +11,7 @@
  * limitations under the License.
  */
 import { Renderer } from 'marked';
+import { escape } from 'marked/src/helpers';
 import Prism from 'prismjs';
 
 export function createRenderer() {
@@ -24,7 +25,9 @@ export function createRenderer() {
     }
     if (!infostring || infostring.length <= 0) {
       return `
-        <pre class="language-text"><code class="language-text">${code}</code></pre>`;
+        <pre class="language-text"><code class="language-text">${escape(
+          code,
+        )}</code></pre>`;
     }
     if (!(infostring in Prism.languages)) {
       throw Error(`Unsupported language "${infostring}"`);

diff --git a/tests/non-js-resources/subtests/service-worker/index.md b/tests/non-js-resources/subtests/service-worker/index.md
@@ -36,9 +36,8 @@ body {
 
 **index.html**
 
-```
-<!DOCTYPE html>
-…
+```html
+<!DOCTYPE html> …
 ```
 
 **sw.js**