Skip to content

Commit

Permalink
Don't use babel when running tests using karma (#398)
Browse files Browse the repository at this point in the history
Currently instrumentation is running after babel, which results in
incorrect and nonsensical coverage information. The node vs. web
coverage here is an example:
https://codecov.io/gh/GoogleChromeLabs/confluence/src/f6802df5a6be89042a1db1e7b82f0a0a90906caf/lib/dao/indexed_dao.es6.js

This could be fixed by changing the order:
#404

However, it's not clear if that's correct:
webpack-contrib/istanbul-instrumenter-loader#86

There's no need to run Babel to test stable versions of Chrome or Firefox,
so just skip babel-loader.
  • Loading branch information
foolip committed May 15, 2019
1 parent f6802df commit f31562a
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions config/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,6 @@ configurator.webpackConfig = {
mode: 'development',
module: {
rules: [
{
test: C.ES6_REG_EXP,
use: [
{
loader: 'babel-loader',
options: C.ES6_LOADER_OPTIONS_DEV,
},
],
},
{
test: /\.html$/,
use: [{loader: 'html-loader'}],
Expand Down

0 comments on commit f31562a

Please sign in to comment.