Prevent endpoint from being closed when at least an object is exposed #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject was exposed on endpoint.
Nemikolh
commented
Mar 2, 2023
| @@ -295,6 +295,9 @@ export function expose( | |||
| ep: Endpoint = globalThis as any, | |||
| allowedOrigins: (string | RegExp)[] = ["*"] | |||
| ) { | |||
| const newCount = (proxyCounter.get(ep) || 0) + 1; | |||
| proxyCounter.set(ep, newCount); | |||
There was a problem hiding this comment.
A few notes:
- I think
proxyCountershould be renamed. MaybeendpointRefCounts? - We might want to return from
Comlink.exposea function that decrement that count (so that this can be cleaned)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #626. I wonder if we should return from
Comlink.exposea function to deincrement that count again?