Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved testing options #459

Closed
wants to merge 10 commits into from
Closed

Improved testing options #459

wants to merge 10 commits into from

Conversation

tunetheweb
Copy link
Member

Improved version of #286

Changes:

  • Allows you to run: npm run test:e2e -- --browser=chrome --metric=TTFB.
  • Adds a precommit test for any stray it.only's or browser.debug's left around.
  • Adds instructions to contributing file.
  • Moves Code of Conduct and Contributing files to more commonly known locations to make them easier to find.

tunetheweb and others added 7 commits March 19, 2024 11:21
* Cap TTFB in attribution

* Refactor

* Tidy up

* Review feedback
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tunetheweb tunetheweb changed the base branch from main to v4 April 4, 2024 22:38
@@ -2,3 +2,11 @@
. "$(dirname -- "$0")/_/husky.sh"

npm exec lint-staged

echo "Checking for leftover it.only's..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check for describe.only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #460


To run an individual test, change `it('test name')` to `it.only('test name')`.

You can also add `await browser.debug()` lines to the individual test files to pause execution, and press `CTRL+C` in the command line to continue the tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point folks to https://webdriver.io/ for more info on how to write/debug tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #460

@tunetheweb
Copy link
Member Author

Closing in favour of #460

@tunetheweb tunetheweb closed this Apr 4, 2024
@tunetheweb tunetheweb deleted the limit-test-to-browser-metric branch April 4, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants