Defer all observers until after activation #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
reviewed
Nov 15, 2022
Co-authored-by: Barry Pollard <barrypollard@google.com>
|
@tunetheweb committed your suggestion. LGTY otherwise? |
tunetheweb
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #271 by adding a new
whenActivatedutility and using it to defer all of theonXXX()metric functions. It also tweaks thegetVisibilityWatcher()logic to better handle prerendering cases (which always happens when thevisibilityStateis "hidden", and are thus tricky to get right).Note: make sure to look at the diff ignoring whitespace, otherwise it looks like much more changed than did.