Ignore TTFB for loads where responseStart is zero #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
commented
Nov 14, 2022
src/onTTFB.ts
Outdated
|
|
||
| // In some cases the value reported is negative or is larger | ||
| // than the current page time. Ignore these cases: | ||
| // https://github.com/GoogleChrome/web-vitals/issues/137 | ||
| // https://github.com/GoogleChrome/web-vitals/issues/162 | ||
| if (metric.value < 0 || metric.value > performance.now()) return; | ||
| if (responseStart < 0 || responseStart > performance.now()) return; |
There was a problem hiding this comment.
Note, I revert this to using responseStart instead of metric.value because metric.value is being clamped at 0 above, which makes this check mostly useless now. Using responseStart reverts the logic to what it was originally trying to check.
tunetheweb
reviewed
Nov 14, 2022
philipwalton
force-pushed
the
xo-response-start
branch
from
bbb5cb7
to
4eea458
Compare
|
Ok, updated and rebased to pick up the latest changes on |
tunetheweb
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #275 by ignoring loads where the
responseStartproperty of the navigation entry is 0. The assumption is thatresponseStartshould never be zero unless the browser is intentionally concealing navigation timing data.