Use the cjs extension for all UMD builds #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #256 by ensuring all UMD builds have the
.cjsextension.I do not believe this requires a breaking change because none of the UMD files in
distwere directly referenced in the documentation examples, and technically the names of these files should be an implementation detail.It's possible some sites were hard-coding these file named in their HTML, but presumably those references include specific versions (also we document that HTML pages should reference the IIFE builds rather than the UMD builds, so in theory this change will only affect node consumers).
If we get reports of any breakage we can always publish both versions, but I'd prefer to see if this will be an issue before adding that for all future v3 builds.