Ensure all deprecated symbols are annotated #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
force-pushed
the
deprecated-annotations
branch
from
378e1fb
to
2865240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the symbols in
deprecated.tsand adds@deprecatedannotations in the JSDoc comments. This should help ensure developers using VSCode (or similar editors that support this) will know that the symbol is deprecated as well as what the updated name is.This PR also adds back the
ReportHandlertype that was accidentally removed in #225. It aliases it toReportCallbackand marks it as deprecated so the change won't be breaking in v3 when it lands.