Update index.js #775
Open
Update index.js #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated code to check the record type and parse if text or URL
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| } | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Shall we have a spacer to make it clear there are multiple records?
There was a problem hiding this comment.
This is a good idea. I want to further parse other types of tags as well. is this fine?
There was a problem hiding this comment.
I'm not sure I'd parse more types in a sample like this.
beaufortfrancois
force-pushed
the
gh-pages
branch
7 times, most recently
from
c198a70
to
03c4155
Compare
beaufortfrancois
force-pushed
the
gh-pages
branch
5 times, most recently
from
1de1b35
to
c4f3954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to check the record type and parse if text or URL