core(trace-elements): include LCP type in artifact #14344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Sep 1, 2022
brendankenny
added a commit
that referenced
this pull request
Sep 1, 2022
brendankenny
added a commit
that referenced
this pull request
Sep 1, 2022
brendankenny
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LCP trace event reports if it was text or an image, which we can use to make tricky image cases easy.
This updates the two LCP image debug audits to use the LCP
typeinformation to mark themselvesnotApplicableif the LCP was text, even whenImageElementssays otherwise due to url matching issues (#13338).The change should be straightforward, but the commits separate the gatherer and audit changes to make it a little easier to review.