core: add priority to network-requests debug audit #14340
Conversation
brendankenny
requested review from
connorjclark
and removed request for
a team
| @@ -73,6 +73,7 @@ class NetworkRequests extends Audit { | |||
| statusCode: record.statusCode, | |||
| mimeType: record.mimeType, | |||
| resourceType: record.resourceType, | |||
| priority: record.priority, | |||
There was a problem hiding this comment.
FYI, this is the "final" priority of the resource. Is this what you need?
lighthouse/core/lib/network-request.js
Line 298 in bb2bed6
I think it'd be good to name this finalPriority to be clear.
There was a problem hiding this comment.
FYI, this is the "final" priority of the resource. Is this what you need?
Yes, that's all that really matters in this case (to really reconstruct the whole load you'll need something like the full devtoolsLog anyways, not just a summary like this).
finalPriority seems OK but if it's compelling enough to change we should switch it on the real network-request and this can be updated to match, rather than going activist in the debug audit :)
There was a problem hiding this comment.
iirc, devtools sdk uses initialPriority but doesn't prefix stuff w/final
(yes im very aware that i heavily advocated for final with our lhr URL names. :)
this is one last major missing piece for analyzing loads from LHRs for preload opportunities. Priority can sometimes be inferred, and critical-request-chains has some of this information, but in practice inference isn't reliable and the crc data format is a nightmare for joining in SQL environments.