core: use trace time origin for main-thread-task time origin #14252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnj
approved these changes
Aug 1, 2022
alexnj
approved these changes
Aug 1, 2022
This was referenced Aug 1, 2022
brendankenny
added a commit
that referenced
this pull request
Aug 2, 2022
brendankenny
added a commit
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the first half of #14226, putting the hidden
main-thread-tasksaudit start times on the same timeline as e.g. the hiddenmetricsdiagnostic audit timestamps.After this change there will be tasks with negative start/endTimes returned from
getMainThreadTasks(). There's no larger effect because no code touches the task start/endTimes except for the hiddenmain-thread-tasksdiagnostic audit. All other audits that usegetMainThreadTasks()just use the task durations.A full fix for #14226 will (probably) remove any tasks happening before the time origin from those summary audits, but this change has no effect on those audits.