tests: retry some jest tests on failure #12298
Conversation
| @@ -142,7 +142,7 @@ | |||
| "glob": "^7.1.3", | |||
| "idb-keyval": "2.2.0", | |||
| "intl-messageformat-parser": "^1.8.1", | |||
| "jest": "^24.9.0", | |||
| "jest": "^26.6.1", | |||
There was a problem hiding this comment.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Has anyone looked into why these are flaky? Does #12284 help? |
havent looked. searching my memory of n=1 data points, |
.github/scripts/jest-retry.sh
Outdated
| set -euxo pipefail | ||
|
|
||
| $* | ||
| $* --onlyFailures --passWithNoTests |
There was a problem hiding this comment.
What about?
$* || $* --onlyFailures
|
i'm gonna retry the actions a few times and see how many times it passes (this PR only impacts some of the unit tests, not smokes...)
|
|
we haven't landed #12284 yet :P |
|
I'm not talking about puppeteer, I'm curious if this PR does anything. I hit a wall with #12284 – next action item is a Chrome bisect but I'm strapped for bandwidth for another couple weeks, so I can't move forward there at the moment. |
|
I haven't seen the unit tests fail here yet; they continue to fail elsewhere (look at latest master CI run). should be an improvement to merge this. Can investigate if still needed even after puppeteer upgrade (altho, I think some failures are not related to puppeteer, I'd have to check again..) |
The failures are real annoying, so SGTM if this was waiting on me :) I'd really like us to not wave off the failures as expected flakiness because I think they've definitely increased in rate recently (it would be nice if Github Actions tracked this), but I don't think there's any problem waiting for the #12284 investigation. |
|
jest 27 is getting a new |
was actually waiting for master to be unbroked. now, it seems windows in GH Actions doesn't use environment variables like the other environments... |
@paulirish mentioned that |
|
last failure was b/c of |
These are too flaky. This should help.