Cli args for wizard #724
Open
Cli args for wizard #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteirard
commented
Nov 12, 2021
| @@ -8,10 +8,13 @@ declare global { | |||
| namespace LHCI { | |||
| namespace WizardCommand { | |||
| export interface Options { | |||
| wizard?: 'new-project' | 'reset-admin-token'; | |||
| wizard?: 'new-project' | 'reset-admin-token' | 'reset-build-token'; | |||
There was a problem hiding this comment.
I think this was missing in the type definition
|
@patrickhulce Just a heads up :) |
patrickhulce
requested changes
Nov 23, 2021
| @@ -489,6 +489,18 @@ The _admin token_ is used to edit or delete data within the project. **KEEP THIS | |||
|
|
|||
| If your lhci server is behind basic auth, you can provide the username and password via the `--basicAuth.password` and `--basicAuth.username` command line flags. | |||
|
|
|||
| All these options are available for `lhci wizard` | |||
There was a problem hiding this comment.
move and link to the configuration docs instead? don't want to have too many places where every flag is documented extensively :)
| @@ -8,10 +8,13 @@ declare global { | |||
| namespace LHCI { | |||
| namespace WizardCommand { | |||
| export interface Options { | |||
| wizard?: 'new-project' | 'reset-admin-token'; | |||
| wizard?: 'new-project' | 'reset-admin-token' | 'reset-build-token'; | |||
| @@ -14,7 +14,7 @@ const btoa = typeof window === 'undefined' ? s => Buffer.from(s).toString('base6 | |||
|
|
|||
| class ApiClient { | |||
| /** | |||
| * @param {{rootURL: string, fetch?: import('isomorphic-fetch'), URL?: typeof import('url').URL, extraHeaders?: Record<string, string>, basicAuth?: LHCI.ServerCommand.Options['basicAuth']}} options | |||
| * @param {{projectExternalUrl?: string, serverBaseUrl?: string, basicAuth?: LHCI.ServerCommand.Options["basicAuth"], wizard?: "new-project" | "reset-admin-token" | "reset-build-token", extraHeaders?: Record<string, string>, storage?: LHCI.ServerCommand.StorageOptions, projectName?: string, projectBaseBranch?: string, rootURL: string}} options | |||
There was a problem hiding this comment.
revert this? it does not accept these options or do anything with them
|
Hey @moshie, any chance you have time to address Patrick's feedback above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for this great repo 馃敟
I just wanted to be able to create a job from my CI to create new projects.
I suppose the easiest way would be to enable CLI args in the CLI
wizardso I just continued the work of #538Let me know if you need anything else