Changes to use CLI args to configure VIEWER_ORIGIN for lighthouse server #1004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I like the solution in #637 which allows us to change the default self-hosted lighthouse report viewer. However, I noticed that the
$VIEWER_ORIGIN
environment variable works only if you build a custom@lhci/server
package. Hence, I made some modifications to configure$VIEWER_ORIGIN
for@lhci/server
via the CLI args.I changed the following things:
--viewer.origin
cli args for server (Default: https://googlechrome.github.io)/v1/viewer/origin
endpoint that retrieves theviewer.origin
valueThis may not be the most optimal solution, so I would appreciate any feedback on my approach and code changes. Thank you :)