Origin trial activation cron job #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrobbins
approved these changes
May 13, 2024
internals/maintenance_scripts.py
Outdated
| today = self._get_today() | ||
| # Get all OT stages. | ||
| ot_stages: list[Stage] = Stage.query( | ||
| ndb.OR( |
There was a problem hiding this comment.
Why not use the IN operator?
There was a problem hiding this comment.
I didn't think to use it, but I think it reads better anyway. 🙂 Interestingly, after reading some more, it seems using the IN and OR operators are functionally identical. I still think it's easier to interpret the meaning using the IN operator.
DanielRyanSmith
force-pushed
the
2024-05-11_ot-activation-cron
branch
from
a71f680
to
066630a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new cron job that will detect origin trials that are scheduled for trial activation and send those activation requests to the to the origin trials API. This cron job will not be formally implemented until endpoint access has been landed on the origin trials API.