Skip to content

Commit

Permalink
Upgrade Flutter Launcher Icons (#1)
Browse files Browse the repository at this point in the history
* Allow compatible args dependency

* Upgrade args dependency

* Also update the main message

* Renamed default example -> default_example as you couldn't use default with flutter create . command

* Reduced size of examples

* Update README.md

Added info to handle incompatible dependency versions

* Fix: Success message printed on exception  (fluttercommunity#225)

* Update README.md

* Updated README & changelog

* Update ios.dart

added missing icons sizes

* added missied sizes for iOS

* add: fallback to local.properties

* add: error message if minSdkValue is not found

* fix: Incorrect version number shown

Thanks to build_version and build_runner the version number is automatically generated after running build_runner and should _hopefully_ be easier to update

Refs: fluttercommunity#350

* Update README.md

* fix: ignore commented minSdkVersion

* style(analysis): formatted

* chore(lints): disabled `sort_constructors_first`

* chore(vscode): add vscode workspace config

* vendor(deps): added new dependencies

checked_yaml,json_annotation for typesafe configs,
cli_util for logging

* feat(web): constants for web platform

* feat(logger): added logger

* feat(web): support for web icons

* feat(cli-option): added --prefix option

--prefix Generates icons in the given path. Used for testing in virtual directory.

Only supports web platform for now

* fix(config): type error when invalid config is passed

* vendor(deps): added test dependencies

* test(fli_config): added tests for fli config

* test(utils): added tests for utils

* test(web): added tests for web icon templates

* fix(logging): added verbose logging to platform failure

* vendor(deps): added mokito for tests

* test(icon_generator): added tests for IconGenerator

* test(web): added tests for web icon generator

* test: added common entrypoint to all tests

This can be used to generate code coverage reports

* chore: setting up automatic deployment of newly published github release

* style: add missing space

Co-authored-by: Mark O'Sullivan <mos182@hotmail.co.uk>

* fix(generator):  fixed typo in a method

* fix(lint): filxed lint warnings for `public_member_api_docs`

* fix(lint): filxed lint warnings for `require_trailing_commas`

* style: sorted imports

* style: sort variable order

* chore(lint): fixed Markdown lint warnings

* docs(web): added web documentation

* ci: added workflow for auto running tests and analyzer for newly opened prs to merge into  master

* chore(test): fix duplicate test runs

* fix tests

* feat(windows): add support for windows closes fluttercommunity#380

* test(windows): added tests for windows

* fix: typos

* style: use relative imports

* refactor: `kWindowsIconSize` to `windowsDefaultIconSize`

* test: checking version number is matching one in pubspec.yaml

* Update lib/main.dart

Co-authored-by: Ratakondala Arun <ratakondalaarun@gmail.com>

* docs(windows): added windows docs

* refactor: renaming method to convert pubspec to map

* fix(android): minSdk not found closes fluttercommunity#384

* style: formatted

* docs(android): added `min_sdk_android` config docs

* docs(android): added `remove_alpha_ios` config docs

closes fluttercommunity#386

* docs(android): added `min_sdk_android` config to example

* Update README.md

fluttercommunity#231 (comment)

From the insight given in the issue above

* refactor:  changed functions to private

* feat(configs):  added new configs to `FlutterLauncherIconsConfig`

added `min_sdk_android` and `remove_alpha_ios` to `FlutterLauncherIconsConfig`

* refactor: added 21 as default min_sdk_android

* chore(release): updated docs with `v0.10.0` release

* chore: update default_example's pubspec

* fix loading config from pubspec.yaml

* refactor package to use FlutterLauncherIconsConfig

* test: use matchers instead of actual values

* chore: updated CHANGELOG

* chore: fix markdown lint warnings

* Fix typos

* feat: fli cli improvement

closes fluttercommunity#400

* chore(docs): update docs

* feat(macos): added support for macos icons

closes fluttercommunity#393

* fix: json indentation

closes fluttercommunity#404

* test(windows): rebuild test mocks

* test(macos): added tests

* docs(macos): added macos attributes

* docs: added sections to attributes

* `repository` & `issue_tracker` added to pubspec

* fix the icons 50 and 57 in contents.json

the 50x50 icons are actually meant for ipad, but in our ios.dart they are marked as iphone. while the 57x57 should be 1x and 2x, while in our ios.dart we're using 1x and 3x

* chore: point `issue_tracker` to github issues

* fix(example): added example for pub.dev closes fluttercommunity#402

* Add extra white line at the end of the file as xcode projects favor having an empty line at the end

* test(mocks): rebuild test mocks

* chore(release): updated version to `v0.10.1`

* chore: updated change log

* chore: add change from fluttercommunity#324

* chore(release): update release version to `v0.11.0`

* Update README.md

Co-authored-by: Mark O'Sullivan <mos182@hotmail.co.uk>

* style(format): format sdk version

* remove .DS_Store

* chore: Fixes typo in unit tests

replaces 'invlaidfliConfigTemplate' for 'invalidfliConfigTemplate'

Signed-off-by: Hugo Branco <hugobrancowb@gmail.com>

* chore: ✂️ Remove unused testing code

Signed-off-by: Hugo Branco <hugobrancowb@gmail.com>

* chore: Formats code running `dart format .`

Signed-off-by: Hugo Branco <hugobrancowb@gmail.com>

* add .pubignore

* refactor: updated dependencies

Had to update the mock dependency as @GenerateNiceMock wasn't working with the previous version

* Don't ignore CHANGELOG.md

Should improve score from 135 to 140/140.
https://pub.dev/packages/flutter_launcher_icons/score

* - Upgraded image:^3.0.2 to image:^4.0.10 and fixed breaking changes done by the upgrade.

* - updated other dependencies

* - downgrade path to 1.8.2

* - updated image to 4.0.11

* - upgraded image to 4.0.13 to fix quality bugs and updated json_serializable to 6.6.1

* - updated image to 4.0.15

* chore: updated test package

* docs: added documentation and disabled linter for some files

* Fix remove alpha for iOS

* chore: updated dependencies to latest

* style: formatted code with `dart format .`

* chore: release prep for v0.13.0

* feat: command to generate config file template

* refactor: added exception handling

* feat: display command to run to use config file

If custom file name is used, then only add `-f` flag to keep it clear

* add support for adaptive icon scaling

* remove alpha and add adaptive background color

* v1.0.0

---------

Signed-off-by: Hugo Branco <hugobrancowb@gmail.com>
Co-authored-by: PiN73 <p97p@ya.ru>
Co-authored-by: Edmon Marine Clota <comlaterra@gmail.com>
Co-authored-by: Mark O'Sullivan <markyosullivan@gmail.com>
Co-authored-by: Mark O'Sullivan <mos182@hotmail.co.uk>
Co-authored-by: Harpreet Sangar <happy_san@protonmail.com>
Co-authored-by: Oleg <oleg.baidalka@gmail.com>
Co-authored-by: Ratakondala Arun <ratakondalaarun@gmail.com>
Co-authored-by: Ben Vercammen <benvercammen@gmail.com>
Co-authored-by: Oleg <130861+bossly@users.noreply.github.com>
Co-authored-by: Adeyanju Akorede <53178226+Lone-Wolf17@users.noreply.github.com>
Co-authored-by: p-mazhnik <pavel.mazhnik@gmail.com>
Co-authored-by: Edward Poot <edwardmp@gmail.com>
Co-authored-by: Pathik Patel <patelpathik1995@gmail.com>
Co-authored-by: adnan <adnanfahedhr@gmail.com>
Co-authored-by: Alexander Saelmans <alexander.saelmans@signify.com>
Co-authored-by: Connectety-T <k8ieunomu@mozmail.com>
Co-authored-by: Hugo Branco <hugobrancowb@gmail.com>
Co-authored-by: Seth Westphal <westy92@users.noreply.github.com>
Co-authored-by: Carlos Humberto <carloshumberto1990@gmail.com>
Co-authored-by: mike-500 <69246756+mike-500@users.noreply.github.com>
Co-authored-by: OutdatedGuy <everythingoutdated@gmail.com>
  • Loading branch information
22 people committed Apr 12, 2023
1 parent c3ffcf4 commit ecce5cf
Show file tree
Hide file tree
Showing 260 changed files with 4,279 additions and 22,692 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/cd-pub-deploy-published-release.yml
@@ -0,0 +1,22 @@
# Deploy new version to pub.dev after a new GitHub release has been published
name: pub.dev auto deployment

on:
release:
types: [published]

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

jobs:
deploy:
runs-on: ubuntu-latest
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Checkout repo
uses: actions/checkout@v2
- name: Run a one-line script
uses: k-paxian/dart-package-publisher@v1.5.1
with:
accessToken: ${{ secrets.PUB_ACCESS_TOKEN }}
refreshToken: ${{ secrets.PUB_REFRESH_TOKEN}}
25 changes: 25 additions & 0 deletions .github/workflows/ci-open-pr.yml
@@ -0,0 +1,25 @@
# Runs all the unit tests and the analyzer for any PR opened to merge into master branch.
#
# This helps ensure we avoid breaking existing functionality and stick to the rules
# defined in the analysis_options.yaml file
name: run tests & analyzer for new pr

on:
pull_request:
branches: [ master ]

# allows for this workflow to be run manually from the Actions tab
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v1.3
- name: get dependencies
run: dart pub get
- name: run tests
run: dart test test/all_tests.dart
- name: run analyzer
run: dart analyze
119 changes: 8 additions & 111 deletions .gitignore
@@ -1,117 +1,14 @@
# Miscellaneous
*.class
*.lock
*.log
*.pyc
*.swp
.DS_Store
.atom/
.buildlog/
.history
.svn/

# IntelliJ related
*.iml
*.ipr
*.iws
.idea/

# Visual Studio Code related
.classpath
.project
.settings/
.vscode/

# Flutter repo-specific
/bin/cache/
/bin/internal/bootstrap.bat
/bin/internal/bootstrap.sh
/bin/mingit/
/dev/benchmarks/mega_gallery/
/dev/bots/.recipe_deps
/dev/bots/android_tools/
/dev/devicelab/ABresults*.json
/dev/docs/doc/
/dev/docs/flutter.docs.zip
/dev/docs/lib/
/dev/docs/pubspec.yaml
/dev/integration_tests/**/xcuserdata
/dev/integration_tests/**/Pods
/packages/flutter/coverage/
version
analysis_benchmark.json

# packages file containing multi-root paths
.packages.generated

# Flutter/Dart/Pub related
**/doc/api/
.dart_tool/
.flutter-plugins
.flutter-plugins-dependencies
**/generated_plugin_registrant.dart
# Files and directories created by pub
.packages
.pub-cache/
.dart_tool/
.pub/
.idea/
build/
flutter_*.png
linked_*.ds
unlinked.ds
unlinked_spec.ds

# Android related
**/android/**/gradle-wrapper.jar
**/android/.gradle
**/android/captures/
**/android/gradlew
**/android/gradlew.bat
**/android/local.properties
**/android/**/GeneratedPluginRegistrant.java
**/android/key.properties
*.jks

# iOS/XCode related
**/ios/**/*.mode1v3
**/ios/**/*.mode2v3
**/ios/**/*.moved-aside
**/ios/**/*.pbxuser
**/ios/**/*.perspectivev3
**/ios/**/*sync/
**/ios/**/.sconsign.dblite
**/ios/**/.tags*
**/ios/**/.vagrant/
**/ios/**/DerivedData/
**/ios/**/Icon?
**/ios/**/Pods/
**/ios/**/.symlinks/
**/ios/**/profile
**/ios/**/xcuserdata
**/ios/.generated/
**/ios/Flutter/.last_build_id
**/ios/Flutter/App.framework
**/ios/Flutter/Flutter.framework
**/ios/Flutter/Flutter.podspec
**/ios/Flutter/Generated.xcconfig
**/ios/Flutter/app.flx
**/ios/Flutter/app.zip
**/ios/Flutter/flutter_assets/
**/ios/Flutter/flutter_export_environment.sh
**/ios/ServiceDefinitions.json
**/ios/Runner/GeneratedPluginRegistrant.*

# macOS
**/macos/Flutter/GeneratedPluginRegistrant.swift

# Coverage
coverage/
# Remove the following pattern if you wish to check in your lock file
pubspec.lock

# Symbols
app.*.symbols
# Directory created by dartdoc
doc/api/

# Exceptions to above rules.
!**/ios/**/default.mode1v3
!**/ios/**/default.mode2v3
!**/ios/**/default.pbxuser
!**/ios/**/default.perspectivev3
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
!/dev/ci/**/Gemfile.lock
.DS_Store
5 changes: 5 additions & 0 deletions .pubignore
@@ -0,0 +1,5 @@
# test directory
/test/*

# other
/flutter_launcher_icons.code-workspace
62 changes: 47 additions & 15 deletions CHANGELOG.md
@@ -1,7 +1,47 @@
# Changelog

## 0.9.1 (20th March 2023)
- Flutter 3.7 support
## 0.13.0 (7th April 2023)

- Fix remove alpha for iOS [#464](https://github.com/fluttercommunity/flutter_launcher_icons/pull/464)
- Updating code style [#472](https://github.com/fluttercommunity/flutter_launcher_icons/pull/472)
- Updated out of bounds dependency [#473](https://github.com/fluttercommunity/flutter_launcher_icons/pull/473)

## 0.12.0 (24th February 2023)

- Updated image package and other packages [#447](https://github.com/fluttercommunity/flutter_launcher_icons/pull/447)

## 0.11.0 (27th September 2022)

- Support for Macos Icons [#407](https://github.com/fluttercommunity/flutter_launcher_icons/pull/407)
- Cli-improvement [#400](https://github.com/fluttercommunity/flutter_launcher_icons/pull/400)
- Add `repository` and `issue_tracker` [#411](https://github.com/fluttercommunity/flutter_launcher_icons/pull/411) (thanks to [@patelpathik](https://github.com/patelpathik))
- Fix indent in web/manifest.json [#407](https://github.com/fluttercommunity/flutter_launcher_icons/pull/407)
- Fix the icons 50 and 57 in `contents.json` [#412](https://github.com/fluttercommunity/flutter_launcher_icons/pull/412) (thanks to [@adnanjpg](https://github.com/adnanjpg))
- Fix typos [#405](https://github.com/fluttercommunity/flutter_launcher_icons/pull/405) (thanks to [@edwardmp](https://github.com/edwardmp))
- Added newline to EOF [#325](https://github.com/fluttercommunity/flutter_launcher_icons/pull/325) (thanks to [@sandersaelmans](https://github.com/sandersaelmans))

## 0.10.0 (2nd August 2022)

- Support for Web Icons [#374](https://github.com/fluttercommunity/flutter_launcher_icons/pull/374)
- Support for Windows Icons [#382](https://github.com/fluttercommunity/flutter_launcher_icons/pull/382)
- Added missing IOS icon sizes [#298](https://github.com/fluttercommunity/flutter_launcher_icons/pull/298)
- Added `min_sdk_android` option [#392](https://github.com/fluttercommunity/flutter_launcher_icons/pull/392)
- Added documentation for `remove_alpha_ios` [#392](https://github.com/fluttercommunity/flutter_launcher_icons/pull/392)
- Fixed issue with loading config from `pubspec.yaml` [#398](https://github.com/fluttercommunity/flutter_launcher_icons/pull/398) (thanks to [@p-mazhnik](https://github.com/p-mazhnik))

## 0.9.3 (6th June 2022)

- Fixes to make sure it works for Flutter v2.8 (thanks to @RatakondalaArun)
- Fixed issue with incorrect version being shown

## 0.9.2 (22nd August 2021)

- Fixed issue where success message printed even when exception occured (thanks to @happy-san)

## 0.9.1 (25th July 2021)

- Upgrade args dependency to ^2.1.1 (thanks to @PiN73 and @comlaterra)
- Upgraded `image` and `test` dependencies

## 0.9.0 (28th Feb 2021)

Expand Down Expand Up @@ -33,12 +73,10 @@
- Lot of refactoring and improving code quality (thanks to @connectety)
- Added correct App Store icon settings (thanks to @richgoldmd)


## 0.7.2 (25th May 2019)

- Reverted back using old interpolation method


## 0.7.1 (24th May 2019)

- Fixed issue with image dependency not working on latest version of Flutter (thanks to @sboutet06)
Expand All @@ -48,11 +86,11 @@

## 0.7.0 (22nd November 2018)

- Now ensuring that the Android file name is valid - An error will be thrown if it doesn't meet the criteria
- Fixed issue where there was a git diff when there was no change
- Fixed issue where iOS icon would be generated when it shouldn't be
- Added support for drawables to be used for adaptive icon backgrounds
- Added support for Flutter Launcher Icons to be able to run with it's own config file (no longer necessary to add to pubspec.yaml)
- Now ensuring that the Android file name is valid - An error will be thrown if it doesn't meet the criteria
- Fixed issue where there was a git diff when there was no change
- Fixed issue where iOS icon would be generated when it shouldn't be
- Added support for drawables to be used for adaptive icon backgrounds
- Added support for Flutter Launcher Icons to be able to run with it's own config file (no longer necessary to add to pubspec.yaml)

## 0.6.1 (26th August 2018)

Expand All @@ -75,27 +113,22 @@

- [Android] Support for adaptive icons added (Suggestion #23)


## 0.4.0 (9th June 2018)

- Now possible to generate icons for each platform with different image paths (one for iOS icon and a separate one for Android)


## 0.3.3 (28th May 2018)

- Upgraded dart image package dependency to 2.0.0 (issue #26)


## 0.3.2 (2nd May 2018)

- Bug fixing


## 0.3.1 (1st May 2018)

- Bug fixing


## 0.3.0 (1st May 2018)

- Fixed issue where icons produced weren't the correct size (Due to images not with a 1:1 aspect r ation)
Expand All @@ -109,7 +142,6 @@
- Fixed iOS default icon name (Thanks to PR #15 - Thank you!)
- Fixed issue #10 where creation of the icons was failing due to the target folder not existing


## 0.2.0 (18th January 2018)

- Ability to create new launcher icons without replacing the old ones added (#6)
Expand Down

0 comments on commit ecce5cf

Please sign in to comment.