fix oceanbase #607
Open
fix oceanbase #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whhe
reviewed
Mar 27, 2024
| var mainTest = map[string]string{ | ||
| "mainTest": `package main | ||
|
|
||
| import ( |
There was a problem hiding this comment.
Is the indentation in the generated code correct?
| @@ -116,7 +116,7 @@ func buildProject(cfgFile string) { | |||
| } | |||
| if p.Driver == "" { | |||
| p.Driver = singleSelect(getWord("choose a driver"), | |||
| []string{"mysql", "postgresql", "sqlite", "mssql"}, "mysql") | |||
| []string{"mysql", "postgresql", "sqlite", "mssql", "oceanbase"}, "mysql") | |||
There was a problem hiding this comment.
Should also add oceanbase after Import and initialize databas (at line 172).
| @@ -238,6 +238,9 @@ func GetCurrentDirectory() string { | |||
| } | |||
|
|
|||
| func installProjectTmpl(p Project, cfg *config.Config, cfgFile string, info *dbInfo) { | |||
| if p.Driver == "oceanbase" { | |||
| p.Driver = "OceanBase" | |||
There was a problem hiding this comment.
Need comment for this replace. And maybe it's better to keep the Driver as oceanbase to avoid mistakes to be introduced by others in the future.
|
The code of the CLI tool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix oceanbase
close #606