Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include project glossaries on branching a project #1848

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

pedro-mendonca
Copy link
Member

@pedro-mendonca pedro-mendonca commented May 16, 2024

Problem

When a user branches a project, the project glossaries and glossary entries aren't cloned.

Some Translation fields weren't also being cloned: (edited)

  • translation_3
  • translation_4
  • translation_5
  • user_id_last_modified

Solution

Include the project glossaries in the cloning procedure.

Fixes #1847

Notes:

  • This PR fixes an old codebase for the currently unused copy_glossary_items_from(), and includes also some missing fields on the cloning method copy_translations_from().
  • As this PR includes the cloning of the Translation Sets related project glossaries, I've added it inside the method copy_sets_and_translations_from() and added this info on the new docblock.
  • I've called copy_glossary_items_from() inside copy_sets_and_translations_from() to avoid another DB ping to get the related translation sets. If is preferred to call the copy_glossary_items_from() directly in duplicate_project_contents_from() please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branching a project doesn't duplicate the project glossaries
1 participant