Include project glossaries on branching a project #1848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user branches a project, the project glossaries and glossary entries aren't cloned.
Some Translation fields weren't also being cloned: (edited)
translation_3
translation_4
translation_5
user_id_last_modified
Solution
Include the project glossaries in the cloning procedure.
Fixes #1847
Notes:
copy_glossary_items_from()
, and includes also some missing fields on the cloning methodcopy_translations_from()
.copy_sets_and_translations_from()
and added this info on the new docblock.copy_glossary_items_from()
insidecopy_sets_and_translations_from()
to avoid another DB ping to get the related translation sets. If is preferred to call thecopy_glossary_items_from()
directly induplicate_project_contents_from()
please let me know.