Refactor: Addressing pull request review comments

dotnet#505
Glen-Nicol-Garmin · Dec 2, 2019 · 015d649 · 015d649
1 parent e1b2261
commit 015d649
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/src/SourceLink.GitWeb/GetSourceLinkUrl.cs b/src/SourceLink.GitWeb/GetSourceLinkUrl.cs
@@ -20,15 +20,14 @@ public sealed class GetSourceLinkUrl : GetSourceLinkUrlGitTask
 
         protected override string BuildSourceLinkUrl(Uri contentUri, Uri gitUri, string relativeUrl, string revisionId, ITaskItem hostItem)
         {
-            var trimLeadingSlash = relativeUrl.TrimStart('/', '\\');
+            var trimLeadingSlash = relativeUrl.TrimStart('/');
             var trimmedContentUrl = contentUri.ToString().TrimEnd('/', '\\');
 
-            /* p = project/path
-             * a = action
-             * hb = SHA/revision
-             * f = repo file path
-             */
-            var gitwebRawUrl = $"{trimmedContentUrl}/?p={trimLeadingSlash}.git;a=blob_plain;hb={revisionId};f=*";
+            // p = project/path
+            // a = action
+            // hb = SHA/revision
+            // f = repo file path
+            var gitwebRawUrl = UriUtilities.Combine(trimmedContentUrl, $"?p={trimLeadingSlash}.git;a=blob_plain;hb={revisionId};f=*");
             return gitwebRawUrl;
         }
     }

diff --git a/src/SourceLink.GitWeb/Microsoft.SourceLink.GitWeb.nuspec b/src/SourceLink.GitWeb/Microsoft.SourceLink.GitWeb.nuspec
@@ -9,9 +9,9 @@
   </metadata>
   <files>
     $CommonFileElements$
-    <file src="**\SourceLink.GitWeb.*" target="tools" />
+    <file src="**\Microsoft.SourceLink.GitWeb.*" target="tools" />
 
     <file src="$ProjectDirectory$\build\*.*" target="build" />
     <file src="$ProjectDirectory$\buildMultiTargeting\*.*" target="buildMultiTargeting" />
   </files>
-</package>
+</package>
diff --git a/...nk.GitWeb/build/SourceLink.GitWeb.targets → ...build/Microsoft.SourceLink.GitWeb.targets b/...nk.GitWeb/build/SourceLink.GitWeb.targets → ...build/Microsoft.SourceLink.GitWeb.targets
diff --git a/...dMultiTargeting/SourceLink.GitWeb.targets → ...eting/Microsoft.SourceLink.GitWeb.targets b/...dMultiTargeting/SourceLink.GitWeb.targets → ...eting/Microsoft.SourceLink.GitWeb.targets