Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node LTS in Travis #1736

Closed
wants to merge 1 commit into from
Closed

Conversation

ggrossetie
Copy link

@ggrossetie ggrossetie commented Mar 5, 2017

Node.js 6.x is now the "active" LTS: https://github.com/nodejs/LTS#lts-schedule

Plus Travis seems to have trouble building the project with Node 4.1

@benmccann
Copy link

The better way to do this might be to reference "lts". See GitbookIO/gitbook-cli#60

@ggrossetie
Copy link
Author

I didn't know you could do this... Where did you find it ? The document on Travis doesn't mention it : https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Specifying-Node.js-versions

@benmccann
Copy link

Hmm, seems like they should add that to the docs. I don't remember where I learned about it

@benmccann
Copy link

I opened a PR to add it to the npm docs: travis-ci/docs-travis-ci-com#1306

@benmccann
Copy link

@AaronO if you're able to merge this PR as well it should fix the Travis build at least. I'm afraid the Appveyor build is harder to fix

@benmccann
Copy link

benmccann commented Jul 20, 2017

@weitzman @mintbridge @mcveat @ludovicofischer @AaronO would one of you be able to merge this PR to fix the Travis build?

@benmccann
Copy link

benmccann commented Jul 29, 2017

@weitzman @mintbridge @mcveat @ludovicofischer @AaronO would you be able to merge this to fix Travis?

@ggrossetie
Copy link
Author

Unfortunately I'm not a GitBook maintainer... 😞

@benmccann
Copy link

@AaronO @jpreynat @SamyPesse @Soreine @zhouzi would you be able to merge this to fix Travis?

@benmccann
Copy link

@Mogztter my change was merged to the Travis docs if you want to update this PR to use the latest lts syntax

@ggrossetie ggrossetie changed the title Use Node 6.x in Travis Use Node LTS in Travis Aug 1, 2017
@ggrossetie
Copy link
Author

@benmccann Done 😉

@benmccann
Copy link

@Mogztter you did something to mess up this PR. It has hundreds of commits on it now

@AaronO AaronO changed the base branch from master to 4.x.x August 6, 2017 23:58
@ggrossetie
Copy link
Author

@benmccann I see only one commit... ?

@benmccann
Copy link

After my comment it says "AaronO changed the base branch to GitbookIO:4.x.x from GitbookIO:master 8 hours ago". I'm guessing that fixed it

@AaronO
Copy link

AaronO commented Aug 7, 2017

@benmccann That's my fault. I moved the old master to 4.x.x and replaced it with the 3.2.x branch, to specifically have bug fixes on the master (fixed an important freeze some users had in a 3.2.3 release).

3.x.x is still the main version used in production, until the new product release is fully rolled out (https://beta.gitbook.com/), so it makes sense to keep that as the master in the meantime.

@benmccann
Copy link

@AaronO does that mean we need to have this PR merged to both master and 4.x.x ?

@AaronO
Copy link

AaronO commented Aug 7, 2017

@benmccann PRs that are focused on fixes should be merged into master first and foremost.

Since this is a "meta" / build related issue it should be merged into both (with master still being the priority)

@benmccann
Copy link

@AaronO thanks for the clarification. it sounds like this should be merged then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants