Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build. Upgrade non-gitbook dependencies #60

Merged
merged 1 commit into from Jul 11, 2017
Merged

Fix the build. Upgrade non-gitbook dependencies #60

merged 1 commit into from Jul 11, 2017

Conversation

benmccann
Copy link
Contributor

No description provided.

@benmccann benmccann force-pushed the travis branch 2 times, most recently from a9af5ed to 658a19f Compare May 13, 2017 16:14
@benmccann benmccann changed the title Use the latest stable node on Travis Fix the build. Upgrade non-gitbook dependencies May 13, 2017
benmccann referenced this pull request May 13, 2017
@SamyPesse
Bump version to 2.3.0
e940bb3
This was referenced May 13, 2017
Closed
Open
@benmccann
Copy link
Contributor Author

@SamyPesse I wanted to get your thoughts on this one. Thanks

@benmccann benmccann force-pushed the travis branch 3 times, most recently from ee3246b to c38ee5a Compare May 24, 2017 16:48
@benmccann
Copy link
Contributor Author

@SamyPesse just a gentle reminder to merge this when you get a chance. thanks!

@benmccann
Copy link
Contributor Author

@SamyPesse any reason not to merge this to fix the build?

@benmccann benmccann mentioned this pull request Jul 10, 2017
Closed
@benmccann
Copy link
Contributor Author

@AaronO @dylang @sindresorhus @SamyPesse @zhouzi would you be able to merge this PR to fix the build?

@AaronO
Copy link
Contributor

AaronO commented Jul 11, 2017

Thanks @benmccann, those changes make sense 👍

@AaronO AaronO merged commit c3cfbf4 into GitbookIO:master Jul 11, 2017
@AaronO
Copy link
Contributor

AaronO commented Jul 11, 2017

@benmccann Sorry for the delayed replies. The team's efforts have been focused on a major product release (gitbook.com, editor, ...) that we'll announce later this week.

@benmccann
Copy link
Contributor Author

Thanks! Any chance it'd be possible to get a new release?

The current version of gitbook-cli is not compatible with npm5 because it has corrupted dependencies. This PR should fix it. See npm/npm#17081

@AaronO
Copy link
Contributor

AaronO commented Jul 11, 2017

@benmccann Yes, I just minted a 2.3.1 release. Give that a try and let me know if it fixes your issue.

@benmccann
Copy link
Contributor Author

Thank you! That did fix it!

@AaronO AaronO mentioned this pull request Jul 12, 2017
Closed
@ashawley ashawley mentioned this pull request Jul 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benmccann @AaronO