Skip to content

roll-forward for gitversion.msbuild #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Jan 8, 2021

Might fix #2502, fix #2518 fix #2519

Unverified

This user has not yet uploaded their public signing key.
@dieterv
Copy link
Contributor

dieterv commented Jan 8, 2021

@arturcic: dotnet.exe build and dotnet.exe test no longer error out with this change. However, dotnet.exe pack still fails with:
C:\Users\dieter\.nuget\packages\gitversion.msbuild\5.6.2-lockfile1.31\tools\GitVersion.MsBuild.targets(110,9): error MSB4044: The "GenerateGitVersionInformation" task was not given a value for the required parameter "Language". [C:\Development\**redacted**\source\**redacted**\**redacted**.csproj]

To avoid confusion, the weird local GitVersion build mentioned is master + #2410 + this merge request (#2521)

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This issue has been resolved in version 5.6.2 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment