Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exopose NoNormalize property for GitVersionTask #1929

Merged
merged 1 commit into from Nov 22, 2019
Merged

Exopose NoNormalize property for GitVersionTask #1929

merged 1 commit into from Nov 22, 2019

Conversation

chuseman
Copy link
Contributor

No description provided.

@arturcic arturcic merged commit 76d4b1f into GitTools:master Nov 22, 2019
@arturcic
Copy link
Member

LGTM!
Thank you so much for your contributions, @chuseman

@arturcic arturcic added this to the 5.1.3 milestone Nov 22, 2019
@chuseman chuseman deleted the add-no-normalize-property branch November 22, 2019 14:23
@fedebn
Copy link

fedebn commented Dec 23, 2019

how to use this property from jenkins?

@asbjornu
Copy link
Member

asbjornu commented Jan 2, 2020

@fedebn, good question. Looks like there's no NoNormalize switch for the command line, @arturcic, @chuseman?

@fedebn
Copy link

fedebn commented Jan 7, 2020

@fedebn, good question. Looks like there's no NoNormalize switch for the command line, @arturcic, @chuseman?

In order to disable the normalizing procedure it is necessary to change the property GitVersion_NoNormalizeEnabled on the jenkins manchine in GitVersionTask.props. From:

<GitVersion_NoNormalizeEnabled Condition="$(GitVersion_NoNormalizeEnabled) == ''">false</GitVersion_NoNormalizeEnabled>

To:

<GitVersion_NoNormalizeEnabled Condition="$(GitVersion_NoNormalizeEnabled) == ''">ture</GitVersion_NoNormalizeEnabled>

the file is located in the nuget packages folder: nuget\packages\gitversiontask\5.1.3\build

@fedebn
Copy link

fedebn commented Jan 7, 2020

LGTM!
Thank you so much for your contributions, @chuseman

I have used the property on my jenkins slave, but i can not build:

gitversiontask\5.1.3\build\GitVersionTask.targets(65,9): warning : It looks like the branch being examined is a detached Head pointing to commit 'e148343'. Without a proper branch name GitVersion cannot determine the build version

C:\Program Files\dotnet\sdk\2.2.107\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.GenerateAssemblyInfo.targets(161,5): error MSB4044: _The "GetAssemblyVersion" task was not given a value for the required parameter "NuGetVersion".

@arturcic arturcic modified the milestones: 5.1.3, 5.1.4 Jan 7, 2020
@fedebn
Copy link

fedebn commented Feb 19, 2020

Any news about this?

@asbjornu
Copy link
Member

@fedebn, you can use this in the latest pre-release builds of 5.1.4, but if you need a stable one you have to wait a bit until we have that finished up.

@fedebn
Copy link

fedebn commented Mar 20, 2020

I have tested latest official release, work properly, and speed up my build on jenkins slave

@asbjornu
Copy link
Member

@fedebn, thanks for reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants