Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Prevent uploading more files than allowed by maxFilesLeft #593

Merged
merged 2 commits into from Oct 29, 2020

Conversation

ath92
Copy link

@ath92 ath92 commented Oct 28, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Related to #565

This is related to a react-dropzone bug (react-dropzone/react-dropzone#1025). I opened a PR there to fix it upstream, but while waiting for that to get merged, we can also provide an easy fix on our end by slicing any new uploads so that the amount of files that actually gets added can never be more than the max number of files left.

…ted to maxFilesLeft, no matter what is passed into it
@github-actions
Copy link

github-actions bot commented Oct 28, 2020

Size Change: +31 B (0%)

Total Size: 1.26 MB

Filename Size Change
./dist/browser.full-bundle.js 644 kB +6 B (0%)
./dist/browser.full-bundle.min.js 372 kB +6 B (0%)
./dist/index.es.js 105 kB +11 B (0%)
./dist/index.js 107 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/css/index.css 23 kB 0 B
./dist/css/index.js 21 B 0 B
./dist/i18n/en.json 824 B 0 B
./dist/i18n/fr.json 1.25 kB 0 B
./dist/i18n/hi.json 1.43 kB 0 B
./dist/i18n/it.json 1.19 kB 0 B
./dist/i18n/nl.json 1.17 kB 0 B
./dist/i18n/ru.json 1.47 kB 0 B
./dist/i18n/tr.json 1.19 kB 0 B

compressed-size-action

@ath92 ath92 merged commit 6e281d4 into master Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-maxfilesleft branch October 29, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants