Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log query params when available #32

Merged
merged 2 commits into from May 29, 2019
Merged

Log query params when available #32

merged 2 commits into from May 29, 2019

Conversation

JulienPradet
Copy link
Contributor

We are doing many requests on the same URL but with different params.
We'd find it useful to have query params to easily reproduce the URLs we want to debug.

This is what this PR stands for. 馃檪

Have a nice day!

@coveralls
Copy link

coveralls commented May 28, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling be2b7de on front-commerce:master into c5cac3d on Gerhut:master.

@Gerhut
Copy link
Owner

Gerhut commented May 28, 2019

Hi @JulienPradet

Thanks for your contribution!

Did you try customizing the logger refer to https://github.com/Gerhut/axios-debug-log#configuration or proposed that this should be the default behavior?

@JulienPradet
Copy link
Contributor Author

JulienPradet commented May 28, 2019

@Gerhut I suggest that this should be the default.
In my experience, the URL without the GET params is not really useful. But I don't know if it is relevant for you.

index.js Outdated Show resolved Hide resolved
test.js Show resolved Hide resolved
@Gerhut Gerhut merged commit 244521b into Gerhut:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants