Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMT-Ghostscript incompatibility: Give recommendations and extend examples #3249

Merged
merged 32 commits into from
May 18, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented May 14, 2024

Description of proposed changes

The incompatibility of some GMT Ghostscript version combinations causes not working transparency.

This PR adds

Related to

Fixes: #3242 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs labels May 14, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.13.0 milestone May 14, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this May 14, 2024
@yvonnefroehlich yvonnefroehlich marked this pull request as draft May 14, 2024 15:04
@yvonnefroehlich yvonnefroehlich changed the title GMT Ghostscript incompatiblity: Update "Getting started", Add note to "Common installation issues", Add reminder to "release checklist" GMT-Ghostscript incompatiblity: Add transparency element to "Getting started", Add note to "Common installation issues", Add reminder to "release checklist" May 14, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
fig.coast(region="g", frame=True, shorelines=1)
fig.coast(projection="N10c", region="g", frame=True, land="tan", water="lightblue")
# Add a semi-transparent text element
fig.text(position="MC", text="PyGMT", font="60p,Helvetica-Bold,red@75")
fig.show()
```
Copy link
Member

@seisman seisman May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can add the image here so that it's more straightforward to see the differences if any. But I'm unsure what's the best way to add the image here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this would definitely be nice! I was also thinking about this while writing the explanation comment. I have to see when I have time to figure out a solution - maybe a table: left the code and right the image?

yvonnefroehlich and others added 5 commits May 15, 2024 07:33
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
README.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/4-release_checklist.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
yvonnefroehlich and others added 8 commits May 15, 2024 20:14
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
doc/install.md Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
yvonnefroehlich and others added 3 commits May 16, 2024 08:09
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
doc/install.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
doc/install.md Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented May 16, 2024

Please also make the PR title shorter.

yvonnefroehlich and others added 4 commits May 16, 2024 20:30
@yvonnefroehlich yvonnefroehlich changed the title GMT-Ghostscript incompatiblity: Add transparency element to "Getting started", Add note to "Common installation issues", Add reminder to "release checklist" GMT-Ghostscript incompatiblity: give suggestions and extend examples May 16, 2024
@yvonnefroehlich yvonnefroehlich changed the title GMT-Ghostscript incompatiblity: give suggestions and extend examples GMT-Ghostscript incompatibility: give recommendations and extend examples May 16, 2024
@yvonnefroehlich yvonnefroehlich changed the title GMT-Ghostscript incompatibility: give recommendations and extend examples GMT-Ghostscript incompatibility: Give recommendations and extend examples May 16, 2024
README.md Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented May 17, 2024

Looks good to me already. Do you still have more changes to add?

@yvonnefroehlich yvonnefroehlich marked this pull request as ready for review May 18, 2024 07:47
@seisman seisman removed the maintenance Boring but important stuff for the core devs label May 18, 2024
@seisman seisman merged commit 8926fde into main May 18, 2024
9 checks passed
@seisman seisman deleted the mention-gs-gmt-transprency branch May 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygmt.show_versions should warn if incompatible packages are installed
3 participants