WIP: pygmt.grdcut: Support both grids and images #3115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
weiji14
reviewed
Mar 22, 2024
seisman
changed the title
seisman
force-pushed
the
datatypes/gmtgrid
branch
3 times, most recently
from
d8f1160
to
d0517e0
Compare
seisman
force-pushed
the
datatypes/gmtgrid
branch
from
d0517e0
to
4ba67df
Compare
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2398 works well for storing output 2-D grid in virtual files, but doesn't work for output images. This PR is an initial try to make PR #2398 support images without too much efforts.
Ideally, we should wrap the
GMT_IMAGEdata structure, which may take more time.