Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude CODE_OF_CONDUCT.md, AUTHORSHIP.md and pygmt/tests directory from distributions #2957

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Exclude CODE_OF_CONDUCT.md, AUTHORSHIP.md and pygmt/tests directory from distributions #2957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ prune .github*
prune ci
prune doc*
prune examples*
prune pygmt/tests*
exclude .dvcignore
exclude .gitignore
exclude .readthedocs.yaml
exclude AUTHORSHIP.md
exclude CODE_OF_CONDUCT.md
exclude CONTRIBUTING.md
exclude Makefile
exclude environment.yml
exclude requirements.txt
exclude pygmt/tests/baseline/*.dvc
6 changes: 1 addition & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ name = "pygmt"
description = "A Python interface for the Generic Mapping Tools"
readme = "README.rst"
requires-python = ">=3.9"
license = {text = "BSD License"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

If you are using a standard, well-known license, it is not necessary to use this field. Instead, you should one of the classifiers starting with License ::. (As a general rule, it is a good idea to use a standard, well-known license, both to avoid confusion and because some organizations avoid software whose license is unapproved.)

weiji14 marked this conversation as resolved.
Show resolved Hide resolved
authors = [{name = "The PyGMT Developers", email = "pygmt.team@gmail.com"}]
keywords = [
"cartography",
Expand Down Expand Up @@ -56,15 +55,12 @@ changelog = "https://www.pygmt.org/latest/changes.html"

[tool.setuptools]
platforms = ["Any"]
include-package-data = true
license-files = ["LICENSE.txt"]
Copy link
Member

@weiji14 weiji14 Jan 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the include-package-data = true line is the same as keeping it, since that's the default according to https://setuptools.pypa.io/en/latest/userguide/datafiles.html#include-package-data (when using setuptools>61.0.0 with pyproject.toml). Maybe just keep the line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have package data to include, so keeping this line may be more confusing (although the default is still true).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm ok, I see you removed the [tool.setuptools.package-data] section, so should be ok to remove it.


[tool.setuptools.packages.find]
include = ["pygmt*"]
exclude = ["doc"]

[tool.setuptools.package-data]
tests = ["data/*", "baseline/*"]

[tool.setuptools_scm]
local_scheme = "node-and-date"
fallback_version = "999.999.999+unknown"
Expand Down