Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip post setup mambaforge in Continuous Integration #2220

Merged
merged 1 commit into from Dec 4, 2022

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 4, 2022

Description of proposed changes

Reduce time spent by conda-incubator/setup-miniconda on the 'Post Setup Mambaforge' step, especially on Windows which could take ~4-6 minutes.

This feature was added in conda-incubator/setup-miniconda#234, and is available since setup-miniconda=2.2.0 updated in #2203. Default setting is run-post: true which will do 'Removing uncompressed packages to trim down cache folder...'. Setting it to run-post: false shouldn't have any side effects since we're not using any cache.

Related to #584.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Reduce time spent by `conda-incubator/setup-miniconda` on the 'Post Setup Mambaforge' step, especially on Windows which could take ~4-6 minutes.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 4, 2022
@weiji14 weiji14 added this to the 0.8.0 milestone Dec 4, 2022
@weiji14 weiji14 self-assigned this Dec 4, 2022
@weiji14 weiji14 marked this pull request as ready for review December 4, 2022 04:49
@weiji14
Copy link
Member Author

weiji14 commented Dec 4, 2022

Example benchmark: windows-latest - Python 3.8 / NumPy 1.21 test took 14m40s at https://github.com/GenericMappingTools/pygmt/actions/runs/3611751950/jobs/6086431051

image

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@weiji14 weiji14 merged commit 8854774 into main Dec 4, 2022
@weiji14 weiji14 deleted the skip-post-mambaforge branch December 4, 2022 12:17
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ools#2220)

Reduce time spent by `conda-incubator/setup-miniconda` on the 'Post Setup Mambaforge' step, especially on Windows which could take ~4-6 minutes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants