Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build system settings to pyproject.toml following pep517 and pep518 #1845

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 24, 2022

Description of proposed changes

The first step to address #1836.

Also xref #695.

References:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Mar 24, 2022
@seisman seisman added this to the 0.6.1 milestone Mar 24, 2022
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, it works great when I tested it locally 😄

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 25, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 26, 2022
@seisman seisman merged commit cd7a62e into main Mar 26, 2022
@seisman seisman deleted the pep-517-518 branch March 26, 2022 07:00
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants