Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tomli as a dependency in GitHub Actions CI #1564

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Add tomli as a dependency in GitHub Actions CI #1564

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
543be1e
Add tomli as a dependency in GitHub Actions CI
weiji14 Oct 3, 2021
86d770c
Just install coverage without the toml specification
weiji14 Oct 3, 2021
b276b43
Remove coverage dependency since it is required by pytest-cov already
weiji14 Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ jobs:
mamba install gmt=6.2.0 numpy=${{ matrix.numpy-version }} \
pandas xarray netCDF4 packaging \
${{ matrix.optional-packages }} \
coverage[toml] dvc=2.3.0 make pytest>=6.0 \
pytest-cov pytest-mpl sphinx-gallery
coverage dvc=2.3.0 make pytest>=6.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why we have coverage here, but not in "ci_tests_dev.yaml"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, git blame shows that coverage[toml] was added by you in #1033, so I'll need to ask you that! We could probably removecoverage though, since pytest-cov depends on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Let's remove it and see everything works well.

pytest-cov pytest-mpl sphinx-gallery tomli

# Show installed pkg information for postmortem diagnostic
- name: List installed packages
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
# Development dependencies
- black
- blackdoc
- coverage[toml]
- coverage
- docformatter
- dvc=2.3.0
- flake8
Expand Down