Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: virtualFile.Read returns EOF with valid data #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: virtualFile.Read returns EOF with valid data #159

wants to merge 2 commits into from

Commits on Jul 6, 2020

  1. Added testing harness for VirtualFiles

    @cmaglie
    cmaglie committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    377224b View commit details
    Browse the repository at this point in the history

  2. Fixed wrong EOF in virtualFile.read method 

    It happens that the read method in VirtualFile may return EOF together
with data. This is not how the os.File behaves normally as explained
in https://golang.org/pkg/os/#File.Read

> func (f *File) Read(b []byte) (n int, err error)
>
> Read reads up to len(b) bytes from the File. It returns the number
> of bytes read and any error encountered. At end of file, Read
> returns 0, io.EOF.
    @cmaglie
    cmaglie committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    01e5be5 View commit details
    Browse the repository at this point in the history