Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-hinting elastica #367

Draft
wants to merge 47 commits into
base: update-0.3.3
Choose a base branch
from
Draft

Type-hinting elastica #367

wants to merge 47 commits into from

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Apr 27, 2024

#255

Policy

  • The entire purpose of type-hinting python library is to enhance the readability and to reduce ambiguity, not to increase the codebase.

Common Types Aliases

Any alias not listed here are subject to change in the future.
included in elastica/typing.py

  • SystemType : any generic object type for simulator (i.e. Rod, RigidBody, etc.)
  • SystemCollectionType : object collection (i.e. BaseSystemCollection or simulator that user defines)
  • OperatorType : any generic step used in timestepper
  • SteppersOperationstype : collection of OperatorType used to define specific timestepper

Note: Casting

  • For now
    • Use np.floating for any float typing
    • Use int for any integer typing

Tasks (blocked by:)

Useful Links

@skim0119 skim0119 changed the base branch from update-0.3.3 to master April 27, 2024 12:14
@skim0119 skim0119 changed the base branch from master to update-0.3.3 April 27, 2024 12:15
@skim0119 skim0119 self-assigned this Apr 28, 2024
@skim0119 skim0119 added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Apr 28, 2024
@skim0119 skim0119 changed the title Update/mypy Type-hinting elastica May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants