-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-hinting elastica #367
Draft
skim0119
wants to merge
47
commits into
update-0.3.3
Choose a base branch
from
update/mypy
base: update-0.3.3
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim0119
added
enhancement
New feature or request
github_actions
Pull requests that update GitHub Actions code
labels
Apr 28, 2024
Typing: timestepper module
Typing: `timestepper` fix pytest and cleanup integration routine
Co-authored-by: Seung Hyun Kim <skim0119@gmail.com>
Typing: Add typehinting for `Rod` modules
Exactly tracing the type for njit dispatched function will only make the code unreadable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#255
Policy
type-hinting
python library is to enhance the readability and to reduce ambiguity, not to increase the codebase.mypy
can easily become cumbersome task. (https://www.reddit.com/r/Python/comments/10zdidm/why_type_hinting_sucks/)Any
or# type: ignore
and we can discuss further during review stage.Common Types Aliases
SystemType
: any generic object type for simulator (i.e.Rod
,RigidBody
, etc.)SystemCollectionType
: object collection (i.e.BaseSystemCollection
or simulator that user defines)OperatorType
: any genericstep
used in timestepperSteppersOperationstype
: collection ofOperatorType
used to define specific timestepperNote: Casting
np.floating
for any float typingint
for any integer typingTasks (blocked by:)
elastica/rod
Typing: Add typehinting forRod
modules #341elastica/timestepper
Typing: timestepper module #372 @skim0119timestepper
fix pytest and cleanup integration routine #373elastica/memory_block
@armantekinalpelastica/rigid_body
@sy-cuielastica/mesh
@Ali-7800elastica/module
@skim0119modules
#382examples
Useful Links