Fix ci and make compatible with Ember 5 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running against Ember 4.4 our CI was failing, because ember-cli-babel incorrectly gets confused about which actual ember-source is in use. --- Without this change, the various ember-cli-babel processes were identifying that ember-source@3.26 was in use and was therefore transpiling all `@ember/***` module usage to `Ember` global usage. This is "fine" for Ember 3.26, but under 3.27+ "real" modules exist and globals rewriting is no longer needed.
Gaurav0
force-pushed
the
fix_ci
branch
2 times, most recently
from
3222a72
to
acd5700
Compare
Gaurav0
force-pushed
the
fix_ci
branch
4 times, most recently
from
38cf419
to
74a747e
Compare
Gaurav0
force-pushed
the
fix_ci
branch
2 times, most recently
from
21e63a7
to
080dcda
Compare
Gaurav0
force-pushed
the
fix_ci
branch
2 times, most recently
from
7a16150
to
b786946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges ember-fastboot#898 , ember-fastboot#907, and ember-fastboot#915
fastboot-shoebox-test was broken by ember-fastboot#905
Anyone is free to pick up this PR and fix the remaining tests for Ember 5.